Content-Length: 307333 | pFad | http://github.com/electric-sql/electric/pull/2829

D8 feat: allow publication alter debounce to be configurable by icehaunter · Pull Request #2829 · electric-sql/electric · GitHub
Skip to content

feat: allow publication alter debounce to be configurable #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

feat: allow publication alter debounce to be configurable #2829

merged 1 commit into from
Jun 16, 2025

Conversation

icehaunter
Copy link
Contributor

@icehaunter icehaunter commented Jun 12, 2025 •
edited
Loading

  • Introduce a tweak variable to debounce ALTER PUBLICATION calls
    • This is currently required for some setups against AWS aurora
  • Fix weird startup order issue
    • We did start schema reconcilier, then schema cache, but essentially first functional line of the reconciler was to call into the schema cache, which was blocked on startup until it could refresh the publication and such. Putting the reconcilier behind schema cache in order makes it so our startup is more linear, and any shape requests that come in during startup (that need a publication alter) will be debounced together with the schema reconciler normalizing the publication

@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (543b204) to head (60160f3).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
+ Coverage   78.08%   78.21%   +0.12%     
==========================================
  Files         154      155       +1     
  Lines        7236     7343     +107     
  Branches      272      274       +2     
==========================================
+ Hits         5650     5743      +93     
- Misses       1584     1598      +14     
  Partials        2        2
Flag Coverage Δ
elixir 77.09% <100.00%> (+0.13%) ⬆️
elixir-client 73.03% <ø> (+3.79%) ⬆️
packages/experimental 88.95% <ø> (+1.22%) ⬆️
packages/react-hooks 86.30% <ø> (ø)
packages/typescript-client 92.41% <ø> (ø)
packages/y-electric 55.12% <ø> (ø)
postgres-140000 77.25% <100.00%> (-0.21%) ⬇️
postgres-150000 77.32% <100.00%> (?)
postgres-170000 77.34% <100.00%> (-0.25%) ⬇️
sync-service 77.63% <100.00%> (-0.25%) ⬇️
typescript 84.54% <ø> (+0.18%) ⬆️
unit-tests 78.21% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alco
alco approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

The only feedback I've got is a bit of rambling on configuration setting naming.

@icehaunter icehaunter force-pushed the ilia/pr/przvnkllmmkq branch from f0e6cc8 to f54d55d Compare June 16, 2025 15:59
@netlify Netlify
Copy link

netlify bot commented Jun 16, 2025

✅ Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit f54d55d
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/68503f450f41b300082142d2
😎 Deploy Preview https://deploy-preview-2829--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@icehaunter icehaunter force-pushed the ilia/pr/przvnkllmmkq branch from f54d55d to 0d54c07 Compare June 16, 2025 16:03
@icehaunter icehaunter force-pushed the ilia/pr/przvnkllmmkq branch from 0d54c07 to 60160f3 Compare June 16, 2025 16:11
@icehaunter icehaunter merged commit 37c5902 into main Jun 16, 2025
39 checks passed
@icehaunter icehaunter deleted the ilia/pr/przvnkllmmkq branch June 16, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alco alco alco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icehaunter @alco








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/electric-sql/electric/pull/2829

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy