feat(sync-service): GenStage telemetry #2837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
- Coverage 78.32% 78.24% -0.08%
==========================================
Files 155 156 +1
Lines 7354 7379 +25
Branches 275 273 -2
==========================================
+ Hits 5760 5774 +14
- Misses 1592 1603 +11
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
benchmark this |
|
Benchmark results, triggered for 2d633
|
alco
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current replication processing time telemetry records overall time and breaks down by it's various parts, however there are gaps in this breakdown and data from trigger.dev shows that a significant amount of time is spent in these gaps.
This PR times all the following 7 intervals (in this order):
3 of these intervals were already available: message_to_collector, partitions.handle_event and dispatcher.dispatch however are now using the new IntervalTimer for consistency.
The new IntervalTimer (and it's sibling ProcessIntervalTimer) have been introduced as many of these intervals are impossible to put spans around due to way GenStage code is structured. ProcessIntervalTimer additionally uses process memory for the times when the timer state cannot be passed around (again due to how GenStage code is structured)