Content-Length: 293376 | pFad | http://github.com/internetarchive/openlibrary/pull/10462

3B Reduce edition match score if one edition is missing a date by hornc · Pull Request #10462 · internetarchive/openlibrary · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce edition match score if one edition is missing a date #10462

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Reduce edition match score if one edition is missing a date #10462

wants to merge 7 commits into from

Conversation

hornc
Copy link
Collaborator

@hornc hornc commented Feb 18, 2025 •
edited
Loading

Closes #10461

It turns out this scenario "importing a pre~1970, without ISBN, record into OpenLibrary, it should never be matched to ANY post-1970 edition with an ISBN" was already covered, and seemingly has been since late 2024.

This PR

  • adds more tests to confirm this
  • add typehints and documentation to related methods
  • makes the difference between a record with a date and one without more negative to potentially avoid false matches (although it was already making the correct determination..)

Technical

Testing

Screenshot

Stakeholders

@hornc hornc force-pushed the ISSUE10461 branch 3 times, most recently from 73c58c8 to f1d59d4 Compare February 18, 2025 03:19
@hornc hornc force-pushed the ISSUE10461 branch 2 times, most recently from d0d24d0 to d171597 Compare February 18, 2025 03:38
@hornc hornc force-pushed the ISSUE10461 branch 2 times, most recently from 38daef7 to f92c2f3 Compare February 18, 2025 04:16
@hornc hornc marked this pull request as ready for review February 19, 2025 20:26
@hornc hornc requested a review from scottbarnes February 19, 2025 21:56
@hornc hornc added Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed] labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbarnes scottbarnes Awaiting requested review from scottbarnes

Assignees
No one assigned
Labels
Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Theme: Testing Involves work related to testing infrastructure, development, and ops. [managed]
Projects
None yet
Milestone
No milestone
1 participant
@hornc








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/internetarchive/openlibrary/pull/10462

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy