feat: upgrade golangci-lint to v2 #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok87
reviewed
May 20, 2025
pkg/razorpay/mock/server_test.go
Outdated
| resp, err = client.Post(server.URL+tc.path, | ||
| "application/json", nil) | ||
| } | ||
| assert.NoError(t, err) | ||
| defer resp.Body.Close() | ||
| defer resp.Body.Close() // nolint:errcheck |
There was a problem hiding this comment.
Yeah, I need to fix this but unsure on how to do this like mentioned in the description. I'll try out something and we can talk through it.
Oh, I missed the go mod checks in the workflow. I'll fix it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Checklist
Additional Information
This upgrade the
golangci-lintfrom v1 to v2 and migrates the.golangci.yaml. This is derived from my contribution to the github-mcp-server which does the same thing.While upgrading the
golangci-lintto v2, I noticed there are a few warnings produced by theerrcheckand other linters from the test files. I have ignored the warnings for now and would love to hear some feedback..