Content-Length: 464886 | pFad | http://github.com/typescript-eslint/typescript-eslint/pull/11385/files

03 chore: remove vestiges of Jest internally by cseas · Pull Request #11385 · typescript-eslint/typescript-eslint · GitHub
Skip to content

chore: remove vestiges of Jest internally #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
* text=auto eol=lf

# force github to treat out custom jest snapshot extension as normal jest snapshots
*.shot linguist-language=Jest-Snapshot
*.shot linguist-generated
packages/scope-manager/src/lib/**/* linguist-generated
2 changes: 1 addition & 1 deletion .github/workflows/nx-migrate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# `nx migrate` when renovate opens a PR to change the version of @nx/workspace.
#
# You will therefore also notice that in the renovate configuration, we ignore any packages which
# Nx will manage for us as part of `nx migrate` such as the remaining @nx/* packages and jest.
# Nx will manage for us as part of `nx migrate` such as the remaining @nx/* packages.

name: Nx Migrate

Expand Down
1 change: 0 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"editorconfig.editorconfig",
"esbenp.prettier-vscode",
"streetsidesoftware.code-spell-checker",
"tlent.jest-snapshot-language-support",
"mrmlnc.vscode-json5",
"vitest.explorer"
],
Expand Down
14 changes: 0 additions & 14 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,5 @@
"javascript.preferences.quoteStyle": "single",
"typescript.preferences.quoteStyle": "single",
"editor.defaultFormatter": "esbenp.prettier-vscode",

// make the .shot files from jest-specific-snapshot act like normal snapshots
"files.associations": {
"*.shot": "jest-snapshot"
},
"vsicons.associations.files": [
{
"icon": "jest_snapshot",
"extensions": [
".shot",
],
"extends": "jest_snapshot"
},
],
"nxConsole.generateAiAgentRules": true,
}
10 changes: 0 additions & 10 deletions docs/contributing/Pull_Requests.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,6 @@ For rule tests we recommend, when reasonable:

AST tests belong in the `ast-spec` package, within `fixtures/` subfolders alongside the AST declarations. Each test has its own `<test-name>/` folder, containing a `fixture.ts` file defining the test, and a `snapshots/` subfolder. Happy-path test folders are stored directly under `fixtures/`; error-path test folders go under `fixtures/_errors/`. You can check out the [`ClassDeclaration` fixtures folder](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/ast-spec/src/declaration/ClassDeclaration/fixtures) for an example of both happy-path and unhappy-path test folders.

### Updating Snapshots

[Jest snapshots](https://jestjs.io/docs/snapshot-testing) are generated for use in some tests, e.g. for [rule schemas](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/schema-snapshots) and [code examples in rule docs](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/docs-eslint-output-snapshots). You may need to re-generate these snapshots after adjusting a rule and/or its documentation, by running the relevant test suite(s) with the `-u` flag:

```bash
cd packages/eslint-plugin
yarn test docs -u
yarn test schemas -u
```

## Raising the PR

Once your changes are ready, you can raise a PR! 🙌
Expand Down
1 change: 0 additions & 1 deletion docs/maintenance/Pull_Requests.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ If there's no backing issue:
- Parenthesis and whitespace (see: `getWrappingFixer`).
- Unions and intersections (see: `unionConstituents` and `intersectionConstituents`).
- Unit tests:
- All lines are covered per the Codecov / `yarn jest path/to/impacted/file --coverage` report.
- Both "positive" and "negative" ("valid" and "invalid") cases exist, if reasonably possible to test for.
- Fixes and suggestions, if present, don't remove `//` or `/*` comments
- `invalid` lint rule errors include line and column information
Expand Down
1 change: 0 additions & 1 deletion packages/scope-manager/tests/eslint-scope/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ The intention is to help us ensure we do not regress functionality compared to t
They have been modified to:

- be written in TypeScript
- work with jest
- work with our folder structure
- adhere to our formatting and linting style

Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/pull/11385/files

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy