Content-Length: 302571 | pFad | http://github.com/typescript-eslint/typescript-eslint/pull/11415

92 test(typescript-estree): use absolute tsconfigRootDir in tests by arunvijo · Pull Request #11415 · typescript-eslint/typescript-eslint · GitHub
Skip to content

test(typescript-estree): use absolute tsconfigRootDir in tests #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test(typescript-estree): use absolute tsconfigRootDir in tests #11415

wants to merge 1 commit into from
+61 −13

Conversation

arunvijo
Copy link

@arunvijo arunvijo commented Jul 20, 2025 •
edited by kirkwaiblinger
Loading

PR Checklist

  • Addresses an existing open issue: N/A (cleanup / dev-experience improvement)
  • That issue was marked as accepting prs (This is dev-quality, does not need issue)
  • Steps in Contributing were taken

Overview

This PR ensures that all test tsconfigRootDir and related filePath values use path.resolve(__dirname, ...) to avoid ambiguity and ensure correctness in different CI/local environments.

Changes:

  • Modified 3 test blocks in getProjectConfigFiles.test.ts to use absolute paths
  • Introduced a helper script replace-tsconfig-paths.js to assist in converting relative paths to absolute
  • Ensured proper import path from 'path' is injected if missing

This helps make test behavior more deterministic and portable.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @arunvijo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 20, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d83608e
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/687d40410f16860008d29d2f
😎 Deploy Preview https://deploy-preview-11415--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 75 (🔴 down 19 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@arunvijo arunvijo closed this Jul 20, 2025
@arunvijo arunvijo changed the title test(estree): use absolute tsconfigRootDir in tests test(typescript-estree): use absolute tsconfigRootDir in tests Jul 20, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 20, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d83608e

Command Status Duration Result
nx test typescript-estree --coverage=false ❌ Failed 20s View ↗
nx run-many -t typecheck ❌ Failed 11s View ↗
nx run typescript-estree:test -- --coverage ❌ Failed 54s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-20 19:21:46 UTC

@arunvijo arunvijo reopened this Jul 20, 2025
@kirkwaiblinger
Copy link
Member

Hi @arunvijo!

We appreciate your interest in contributing. However, this PR is clearly bad AI slop, and as a result, we are closing it.

Please only contribute code which you have given thought to and can understand and defend. Thanks.

@kirkwaiblinger kirkwaiblinger mentioned this pull request Jul 21, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunvijo @kirkwaiblinger








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/pull/11415

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy