fix: normalize tsconfigRootDir to handle trailing path separators in project: true #11419
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project: true Fixes typescript-eslint#11413 When using project: true, the search for tsconfig.json files would stop prematurely if sconfigRootDir contained a trailing path separator. This was due to an incorrect length comparison that included the trailing separator character. The fix normalizes the tsconfigRootDir path and removes trailing separators before comparing lengths, ensuring consistent behavior regardless of whether the path ends with '/' or '\'. Changes: - Modified getProjectConfigFiles to normalize tsconfigRootDir path - Added test case to verify fix works with trailing separators - Maintains backward compatibility with existing functionality
|
Thanks for the PR, @gingeekrishna! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit eefbc4c
☁️ Nx Cloud last updated this comment at |
- Use simpler regex-based approach instead of path.normalize - Add safeguard for edge cases where path becomes empty - Remove platform-specific test that might cause CI issues - Maintain backward compatibility with minimal change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[…project: true](fix: normalize tsconfigRootDir to handle trailing path separators in project: true)
Fixes #11413
When using project: true, the search for tsconfig.json files would stop prematurely if sconfigRootDir contained a trailing path separator. This was due to an incorrect length comparison that included the trailing separator character.
The fix normalizes the tsconfigRootDir path and removes trailing separators before comparing lengths, ensuring consistent behavior regardless of whether the path ends with '/' or ''.
Changes:
PR Checklist
Overview