Content-Length: 359678 | pFad | http://github.com/typescript-eslint/typescript-eslint/pull/9788/files

3F fix(utils): add `TSDeclareFunction` to `functionTypeTypes` by abrahamguo · Pull Request #9788 · typescript-eslint/typescript-eslint · GitHub
Skip to content

fix(utils): add TSDeclareFunction to functionTypeTypes #9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2024
Merged

fix(utils): add TSDeclareFunction to functionTypeTypes #9788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e508e1
add tsdeclarefunction
abrahamguo Aug 13, 2024
3c288cc
Merge branch 'main' of github.com:abrahamguo/typescript-eslint into t…
abrahamguo Aug 14, 2024
5a425ff
add newly valid test
abrahamguo Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/eslint-plugin/src/rules/no-redundant-type-constituents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import {
arrayGroupByToMap,
createRule,
getParserServices,
isFunction,
isFunctionType,
isFunctionOrFunctionType,
isTypeAnyType,
isTypeBigIntLiteralType,
isTypeNeverType,
Expand Down Expand Up @@ -171,7 +170,7 @@ function describeLiteralTypeNode(typeNode: TSESTree.TypeNode): string {
function isNodeInsideReturnType(node: TSESTree.TSUnionType): boolean {
return !!(
node.parent.type === AST_NODE_TYPES.TSTypeAnnotation &&
(isFunctionType(node.parent.parent) || isFunction(node.parent.parent))
isFunctionOrFunctionType(node.parent.parent)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFunctionOrFunctionType simply combines the checks of the two functions into one

);
}

Expand Down
1 change: 1 addition & 0 deletions packages/eslint-plugin/tests/rules/no-redundant-type-constituents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ ruleTester.run('no-redundant-type-constituents', rule, {
type T = 'a' | 1 | 'b';
type U = T & string;
`,
"declare function fn(): never | 'foo';",
],

invalid: [
Expand Down
1 change: 1 addition & 0 deletions packages/utils/src/ast-utils/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const functionTypeTypes = [
AST_NODE_TYPES.TSCallSignatureDeclaration,
AST_NODE_TYPES.TSConstructorType,
AST_NODE_TYPES.TSConstructSignatureDeclaration,
AST_NODE_TYPES.TSDeclareFunction,
AST_NODE_TYPES.TSEmptyBodyFunctionExpression,
AST_NODE_TYPES.TSFunctionType,
AST_NODE_TYPES.TSMethodSignature,
Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/pull/9788/files

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy