Content-Length: 296560 | pFad | https://github.com/electric-sql/electric/pull/2626

1F elixir-client: Stop explicitly obfuscating the DB password by alco · Pull Request #2626 · electric-sql/electric · GitHub
Skip to content

elixir-client: Stop explicitly obfuscating the DB password #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alco
Copy link
Member

@alco alco commented Apr 21, 2025

@alco alco force-pushed the alco/client-password-obfuscation branch 2 times, most recently from d989674 to edde389 Compare April 21, 2025 14:37
@alco alco changed the title Starting with Electric v1.0.6 it is not necessary to explicitly obfuscate the DB password elixir-client: Stop explicitly obfuscating the DB password Apr 21, 2025
…cate the DB password

However, v1.0.6 is not published on hex.pm. Just use the latest
published version available.
@alco alco force-pushed the alco/client-password-obfuscation branch from edde389 to 4f9bf11 Compare June 13, 2025 14:51
@alco alco marked this pull request as ready for review June 13, 2025 14:51
@alco alco requested a review from magnetised June 13, 2025 14:51
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (968c5a6) to head (4f9bf11).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
+ Coverage   76.93%   78.33%   +1.40%     
==========================================
  Files         147      154       +7     
  Lines        6612     7271     +659     
  Branches      105      272     +167     
==========================================
+ Hits         5087     5696     +609     
- Misses       1524     1573      +49     
- Partials        1        2       +1     
Flag Coverage Δ
elixir 77.26% <ø> (ø)
elixir-client 72.58% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.30% <ø> (ø)
packages/typescript-client 92.41% <ø> (?)
packages/y-electric 55.12% <ø> (ø)
postgres-140000 77.47% <ø> (ø)
postgres-150000 77.52% <ø> (?)
postgres-170000 77.52% <ø> (-0.02%) ⬇️
sync-service 77.85% <ø> (ø)
typescript 84.36% <ø> (+12.02%) ⬆️
unit-tests 78.33% <ø> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alco
Copy link
Member Author

alco commented Jun 16, 2025

@magnetised Please take a look and see if it makes sense.

config :electric_client, database_config: connection_opts is only used in tests, as far as I can tell, so it can be deobfuscated there, i.e. no need for connection opt processing in the config file.

config electric, replication_connection_opts: ... is passed to StackSupervisor which does the obfuscation, so again -- no need for the explicit call in the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/electric-sql/electric/pull/2626

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy