Content-Length: 293354 | pFad | https://github.com/electric-sql/phoenix_sync/pull/23

52 Starting with Electric v1.0.6 it is not necessary to explicitly obfuscate the DB password by alco · Pull Request #23 · electric-sql/phoenix_sync · GitHub
Skip to content

Starting with Electric v1.0.6 it is not necessary to explicitly obfuscate the DB password #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Starting with Electric v1.0.6 it is not necessary to explicitly obfuscate the DB password #23

wants to merge 1 commit into from

Conversation

alco
Copy link
Member

@alco alco commented Apr 21, 2025 •
edited
Loading

@magnetised Looking at

phoenix_sync/lib/phoenix/sync/electric.ex

Lines 371 to 387 in 61899e2

defp obfuscate_credentials(opts) do
opts
|> Keyword.update!(:replication_connection_opts, &Electric.Utils.obfuscate_password/1)
|> then(fn opts ->
case Keyword.fetch(opts, :query_connection_opts) do
:error ->
opts
{:ok, query_connection_opts} ->
Keyword.put(
opts,
:query_connection_opts,
Electric.Utils.obfuscate_password(query_connection_opts)
)
end
end)
end

is there still a need to do this explicit obfuscation, given that we obfuscate passwords in StackSupervisor's startup anyway?

Mirror PR: electric-sql/electric#2626

@alco alco mentioned this pull request Apr 21, 2025
Open
@alco alco force-pushed the alco/database-url-obfuscation branch from f3e579c to 67c0e30 Compare April 21, 2025 14:34
@alco
Starting with Electric v1.0.6 it is not necessary to explicitly obfus…
a0569f3 
…cate the DB password

However, v1.0.6 is not published on hex.pm. Just use the latest
published version available.
@alco alco force-pushed the alco/database-url-obfuscation branch from 67c0e30 to a0569f3 Compare April 21, 2025 14:40
@magnetised
Copy link
Contributor

We're currently locked at electric 1.0.1 because of the major config changes after that. Once I update the config here to match the new config in electric I'll include this

magnetised added a commit that referenced this pull request May 20, 2025
@magnetised
remove password obfuscation
93385cf 
now handled by electric automatically

replaces #23
@magnetised magnetised mentioned this pull request May 20, 2025
Merged
magnetised added a commit that referenced this pull request May 20, 2025
@magnetised
Bump requirements to allow current electric (#44)
c42c68a 
set minimum to 1.0.6 to include password obfuscation changes

replaces #23
@magnetised
Copy link
Contributor

Done as part of #44 - thanks @alco

@magnetised magnetised closed this May 20, 2025
@alco alco deleted the alco/database-url-obfuscation branch May 21, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alco @magnetised








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/electric-sql/phoenix_sync/pull/23

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy