Fix publish year graph on subjects pages no longer filtering #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nside of Carousel.js
for more information, see https://pre-commit.ci
cdrini
approved these changes
Apr 28, 2024
cdrini
changed the title
merwhite11
pushed a commit
to merwhite11/openlibrary
that referenced
this pull request
May 2, 2024
…#9170) Co-authored-by: Daniel Chen <yumpty@daniels-air-10.wifi.local.cmu.edu> Co-authored-by: pust1n <justin686867@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8962
Fixes bug such that certain year in Publishing history now properly limits carousel works to the clicked year
Technical
Implementation gets rid of an unrequired input into the fetchMore inside of Carousel.js Also, the previous for loop was left on lines 191-193 such that if any other parameters need to be added into url.searchParams, the code still works as expected and no changes should be required.
Testing
Go into Books section on Open Library. Highlight the Graph underneath the Carousel for specific year range and notice how the Carousel matches the Books and year range from the graph.
Screenshot
Stakeholders
@cdrini