Read edition identifiers from file #9483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of this PR, we should deprecate https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/openlibrary/pages/config_edition.page and remove it from the repo |
jimchamp
added
the
Needs: Special Deploy
Removed by af72a03 |
Freso
added a commit
to Freso/openlibrary
that referenced
this pull request
Aug 26, 2024
This is taking the same steps applied to editions[1] and authors[2] and applying it to works. `get_work_config()` is currently not used for anything, probably because we’re still waiting for an actual interface to edit the Work identifiers[3], so this is more a preliminary step to ensure that Works will be handled in the same way that Editions and Authors are. (And to allow for PRs to add Work identifiers while waiting for that UI.) [1] internetarchive#9234 internetarchive#9483 [2] internetarchive#9666 internetarchive#9769 [3] internetarchive#3430
Freso
added a commit
to Freso/openlibrary
that referenced
this pull request
Aug 27, 2024
This is taking the same steps applied to editions[1] and authors[2] and applying it to works. `get_work_config()` is currently not used for anything, probably because we’re still waiting for an actual interface to edit the Work identifiers[3], so this is more a preliminary step to ensure that Works will be handled in the same way that Editions and Authors are. (And to allow for PRs to add Work identifiers while waiting for that UI.) [1] internetarchive#9234 internetarchive#9483 [2] internetarchive#9666 internetarchive#9769 [3] internetarchive#3430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9234
When
get_edition_config()is called, configured edition identifiers are now read from a new, version-controlled file.This change does not affect the
/config/editionobject, meaning that changes to the versioned file will not trigger an update to the/config/editionobject.Marked as Needs: Special DeployThis PR will need a non-standard deploy to production
because
/config/edition.ymlshould be updated to remove identifiers after this is moved to production.Technical
Testing
Screenshot
Stakeholders