#9253 Removed the "in English" link from the editions list on a work page. #9692
Conversation
|
@RayBB Kindly review my PR. |
There was a problem hiding this comment.
I deployed this to testing and it does appear to be removing the links as can be seen here.
However, lets use the commify_list function again.
Also, please provide screenshots of what it looks like before and after your change and in the case where multiple languages are assigned to the edition.
Thanks for you contributions!
| @@ -64,7 +64,7 @@ | |||
| <!-- Formats are store as a raw string --> | |||
| $book.physical_format.replace('[', '').replace(']','') | |||
| $if book.languages: | |||
| $:_('in %(languagelist)s', languagelist=commify_list(thingrepr(l) for l in book.languages)) | |||
| $:_('in %(languagelist)s', languagelist=', '.join(l.name for l in book.languages)) | |||
There was a problem hiding this comment.
Was there a particular reason you removed commify_list here and replaced it with ', '.join ?
If not, lets put it back since it was probably there for a reason and it used in the other places where we are displaying languages.
@RayBB done!! Kindly review. |
RayBB
added
the
Needs: Staff / Internal
Sounds good :) |
|
@RayBB or @poojatalele could we get a clearer title to this one? The title of a PR should be understandable without a lot of extra context. Thank you! |
poojatalele
changed the title
@cdrini Changed, pls check once. |
mekarpeles
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
cdrini
added
On testing.openlibrary.org
and removed
Needs: Staff / Internal
…list on a work page. (internetarchive#9692) Co-authored-by: Drini Cami <cdrini@gmail.com>
…list on a work page. (internetarchive#9692) Co-authored-by: Drini Cami <cdrini@gmail.com>
Closes #9253
hotfix
Technical
This pull request addresses the issue of the "in English" link in the editions list on the work page. The link has been converted to plain text to improve the user experience by removing unnecessary navigation. The changes were made in the template file to render the language text as plain text instead of a hyperlink.
Testing
Screenshot
Before changes:
After changes:
Stakeholders
@RayBB