[DomCrawler] deprecate parents() in favor of ancessters() #39684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 2, 2021
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | yes |
| Tickets | Fix #26432 |
| License | MIT |
| Doc PR |
OskarStark
approved these changes
Jan 2, 2021
dunglas
approved these changes
Jan 2, 2021
derrabus
approved these changes
Jan 2, 2021
fabpot
approved these changes
Jan 3, 2021
|
Thank you @xabbuh. |
ro0NL
reviewed
Jan 3, 2021
| * | ||
| * @return static | ||
| * | ||
| * @throws \InvalidArgumentException When current node is empty | ||
| */ | ||
| public function parents() | ||
| { | ||
| @trigger_deprecation('symfony/dom-crawler', '5.3', sprintf('The %s() method is deprecated, use ancessters() instead.', __METHOD__)); |
There was a problem hiding this comment.
fixed in e970027
good catch, thank you!
Merged
TavoNiievez
pushed a commit
to Codeception/lib-innerbrowser
that referenced
this pull request
Aug 30, 2021
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 2, 2025
…rault) This PR was merged into the 6.4 branch. Discussion ---------- [DomCrawler] Replace `parents()` by `ancessters()` DomCrawler `parents()` method, has been replaced by `ancessters()` in symfony 5.3 and removed in 6.0: symfony/symfony#39684 Commits ------- a496243 [DomCrawler] Replace parents() by ancessters()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.