-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
push to stable #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
push to stable #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
push to hidden
The value of `classified`, `bits_new`, and `cksum`, were not always correctly maintained. 1. In the past, `afl->queue_top->exec_cksum` was always assigned when `add_to_queue`, however it became conditional since cd57641. This doesn't change correctness because calibrate_case() will calculate the checksum. However, this mean one calibration run is wasted. 2. Sometimes `classified` is set incorrectly. For example, this code snippet ``` new_bits = has_new_bits_unclassified(afl, afl->virgin_bits); classified = 1; ``` should be changed to ``` new_bits = has_new_bits_unclassified(afl, afl->virgin_bits); if (new_bits) classified = 1; ``` This commit fixed above issues and use macros to make the code easier to understand. This should prevent to forget to set classified in the future (like the bug fixed by 30c93d1). The macros also defers the calculations to where the values are really needed. This could save cpu if the code returns earlier. For example, if a case is timeout first and not timeout the second time, the current code does classify_counts, which is not always needed.
Refactor and simplify handling of AFL_PRELOAD
instrument all hidden edges
domenukk
reviewed
May 23, 2025
[https://github.com/zardus/preeny](https://github.com/zardus/preeny) or | ||
[https://github.com/fkie-cad/libdesock](https://github.com/fkie-cad/libdesock) | ||
[https://github.com/zyingp/desockmulti](https://github.com/zyingp/desockmulti) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could all be rewritten from
[https://github.com/zyingp/desockmulti](https://github.com/zyingp/desockmulti)
to just
<https://github.com/zyingp/desockmulti>
domenukk
approved these changes
May 23, 2025
fix save_if_interesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.