Don't clear the screen when printing stats #2499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if we could add one final print of stats to the normal buffer before we exit, so the latest stats can persist in the terminal scrollback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2498
The way most applications (btop/htop etc) do this stats-type screen is switch to an alternate screen buffer on entry, and switch back on exit. Doing the same seems to work pretty well.
That being said it might be smarter to do this switch right after "[+] All set and ready to roll!" and return back on exit, instead of swapping buffers on each display. If theres a nice "entrypoint" and "exitpoint"-type place to put these swaps, let me know.