Skip to content

pinned version for dependencies #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2018

Conversation

Sapbasu15
Copy link
Contributor

pinned version for dependencies to resolve issue #99

@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage decreased (-0.2%) to 67.62% when pulling 72a8383 on Sapbasu15:future into 0d238cb on AuthorizeNet:future.

@predatell
Copy link

Why do you decide to do this? It is bad practice.

@predatell
Copy link

Don't add versions for requests, lxml, nose, mock. You will create problems for users. You must set the versions of packages in install_requires section only if you know that your app does not work with that versions of apps. install_requires section is for restrictions for app. So users who have version 2.18.5 or 2.18.3 of requests package can not use your app???

Example 1. Maintainers of requests package will make release with new version 2.18.5 tomorrow with small changes in docs. But your package will have restriction 'requests==2.18.4'. Why users can not use new version of requests package? Or you want to update your package on any new release of related packages?

Example 2. Users can use many packages in one project. You added restriction: 'requests==2.18.4'. If owners of other packages will use your practice then user can have 5-10 packages with "requests" in their "install_requires" with different versions. One of the packages of project can not work with requests with version 2.18.4, but can work with 2.18.3, but your package has 2.18.4... Why do you restrict this user? Because your app can work with version 2.18.3

@predatell
Copy link

If you want to add versions to install_requires, please do it in this way (example):

install_requires=['pyxb==1.2.5', 'lxml>=4.0.0', 'requests>=2.0.0'],

Don't restrict users to only one certain version of package!

@Sapbasu15
Copy link
Contributor Author

@predatell we'll be allowing the version range but with the same major version as the major version change risks backward compatibility. We'll have to manually test and update before a dependency major version is upgraded.

@sunnyrajrathod sunnyrajrathod merged commit 091009c into AuthorizeNet:future Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy