Skip to content

Remove Codeception explicit installation #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Remove Codeception explicit installation #124

merged 1 commit into from
Jan 22, 2017

Conversation

lucatume
Copy link
Contributor

Due to a conflict between the version of symfony/console the wp-cli/wp-cli package requires installing codeception/codeception before lucatume/wp-browser will fail; simply requiring lucatume/wp-browser will fix this while still pulling codeception/codeception latest version.

Due to a conflict between the version of `symfony/console` the `wp-cli/wp-cli` package requires installing `codeception/codeception` before `lucatume/wp-browser` will fail; simply requiring `lucatume/wp-browser` will fix this while still pulling `codeception/codeception` latest version.
@Naktibalda
Copy link
Member

The right solution would be to update wp-cli to support Symfony 3.x components, but it looks like they are actively refusing to do that wp-cli/wp-cli#3635

Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a pull request to 2.2 branch, master is not going anywhere anytime soon.

@Naktibalda Naktibalda dismissed their stale review January 20, 2017 10:06

wrong repo

Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought that this PR is to codeception/codecetion, master branch is correct for this repo.

@DavertMik
Copy link
Member

Thanks!

@DavertMik DavertMik merged commit a1c28be into Codeception:master Jan 22, 2017
@lucatume lucatume deleted the patch-5 branch January 23, 2017 08:20
@lucatume
Copy link
Contributor Author

Thanks a lot for your work guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy