Correcting Bootstrap container usage. #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the container from around bootstrap.html 'content'...
<div class="container"> {{ content }} </div>
...and put it around the inner layouts. This allows the use of container-fluid, eg. to fix the hero unit on the main page. Simplifies the CSS file as well.
Clicked through all the pages I could find, didn't find any broken layouts from this change.
Prettify ‘thanks’ download pages.
|
Added fix for issue #72. This'll probably be the last PR for a while. The site is improved. There's some goofy layout issues that are not really worth tracking down. I think the next step is doing a fresh start in Bootstrap 4 (assuming Codeception site is not seeing much IE8 and IE9 traffic). |
|
@cjaoude thanks for your work! I think I will add some improvements of my own too, to reshape side for 2.2 launch. Could you merge your changes with master, as currently automerge is disabled. |
# Conflicts: # install.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the container from around bootstrap.html 'content'...
...and put it around the inner layouts. This allows the use of container-fluid, eg. to fix the hero unit on the main page. Simplifies the CSS file as well.
Clicked through all the pages I could find, didn't find any broken layouts from this change.