Add OVAL for encrypt_partitions rule #13539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
jan-cerny
reviewed
Jun 5, 2025
linux_os/guide/system/software/disk_partitioning/encrypt_partitions/oval/shared.xml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/software/disk_partitioning/encrypt_partitions/oval/shared.xml
Outdated
Show resolved
Hide resolved
|
|
||
| <linux:partition_state id="state_non_pseudo_file_systems" version="1"> | ||
| <linux:uuid operation="pattern match">.+</linux:uuid> | ||
| <linux:fs_type operation="not equal">iso9660</linux:fs_type> |
There was a problem hiding this comment.
Why is this one special?
There was a problem hiding this comment.
It is collected by partition_object But I wouldn't say it is a partition in the system, this is a cdrom
| @@ -0,0 +1,50 @@ | |||
| <def-group> | |||
There was a problem hiding this comment.
I suggest adding a warning to the rule.yml that the rule doesn't have a remediation.
Co-authored-by: Jan Černý <jcerny@redhat.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
|
Code Climate has analyzed commit c79348e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints: