Skip to content

Fix handling of mysql passwords with weird characters in it #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix handling of mysql passwords with weird characters in it #2660

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7ce8d16
URL encode variables that go into a MySQL credentials URI
eldering Aug 25, 2024
49357f1
Fixes for supporting passwords with weird characters
eldering Nov 22, 2024
f832b11
Set a more grep-able mysql root password in CI jobs, drop domjudge user
eldering Nov 25, 2024
32e2ec5
Test plenty of weird characters in CI job MySQL password
eldering Aug 25, 2024
f216b06
Use our standard script to create database
eldering Nov 23, 2024
cc8f0e5
Call read_dbpasswords outside of update_passwords function
eldering Jul 5, 2025
1882b26
DEBUG
eldering Nov 24, 2024
428621d
Don't pass DBUSER/PASSWD to symfony_console, always construct URL
eldering Nov 25, 2024
b7e0ca2
DEBUG simple password
eldering Nov 25, 2024
ba598f9
Set a more grep-able admin password
eldering Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test plenty of weird characters in CI job MySQL password
  • Loading branch information
@eldering
eldering committed Jul 5, 2025
commit 32e2ec56c20c9eafe350b5e3a3488bf08f027a77
3 changes: 2 additions & 1 deletion .github/jobs/baseinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ mysql_log "CREATE DATABASE IF NOT EXISTS \`$DATABASE_NAME\` DEFAULT CHARACTER SE
mysql_log "CREATE USER IF NOT EXISTS \`domjudge\`@'%' IDENTIFIED BY 'domjudge';"
mysql_log "GRANT SELECT, INSERT, UPDATE, DELETE ON \`$DATABASE_NAME\`.* TO 'domjudge'@'%';"
mysql_log "FLUSH PRIVILEGES;"
echo "unused:sqlserver:$DATABASE_NAME:domjudge:domjudge:3306" > /opt/domjudge/domserver/etc/dbpasswords.secret
echo 'unused:sqlserver:$DATABASE_NAME:domjudge:domjudge_db-pw+% #$*)@(!/;,.:3306' > /opt/domjudge/domserver/etc/dbpasswords.secret

# Show some MySQL debugging
mysql_log "show databases"
Expand All @@ -89,6 +89,7 @@ if [ "${db}" = "install" ]; then
section_end
elif [ "${db}" = "upgrade" ]; then
section_start "Upgrade DOMjudge database"
/opt/domjudge/domserver/bin/dj_setup_database update-password
/opt/domjudge/domserver/bin/dj_setup_database upgrade
section_end
fi
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy