fix(prof): Do not call zend_jit_status() on affected versions
#3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zend_jit_status() on affected versionszend_jit_status() on affected versions
zend_jit_status() on affected versionszend_jit_status() on affected versions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3356 +/- ##
=======================================
Coverage 61.92% 61.92%
=======================================
Files 140 140
Lines 12356 12356
Branches 1616 1616
=======================================
Hits 7651 7651
Misses 3995 3995
Partials 710 710 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2025-07-28 14:27:25 Comparing candidate commit 7d78a4d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
1e4974c to
e17191c
Compare
65abe9e to
7cbc033
Compare
7cbc033 to
7d78a4d
Compare
morrisonlevi
approved these changes
Jul 28, 2025
sydney-tung
pushed a commit
that referenced
this pull request
Jul 30, 2025
* do not call `zend_jit_status()` on affected versions * upstream PR not yet merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a use-after-free crash which we need to work around.
I've already prepared for the upstream fix to be merged and added some version checks that are all commented out at this point in time and should have the comment removed and version number fixed once the upstream PR has landed.
PROF-12148
Reviewer checklist