feat: Added shadow theme set (Red, Green, Blue, Orange, Purple, Brown) #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Just a suggestion regarding the colors -- On light theme, the contrast seems fine, but it seems that on dark mode there is very little contrast making it difficult to read on all of these. If the background is transparent, I think it would help to make the colors lighter and more vibrant. This is what is currently looks like on dark mode:
Feel free to let me know what you think. |
|
Preferably, a separate pull request should be opened to update the translations. Each PR should be focused on one feature. |
|
Ok, I will close this PRs and then re-create new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6 new themes which have a transparent background.
Details
Shadow Red theme preview
Preview Link
Shadow Green theme preview
Preview Link
Shadow Blue theme preview
Preview Link
Shadow Orange theme preview
Preview Link
Shadow Purple theme preview
Preview Link
Shadow Brown theme preview
Preview Link