Skip to content

feat: Added excluding in Japanese #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: Added excluding in Japanese #602

wants to merge 1 commit into from

Conversation

Achixz
Copy link

@Achixz Achixz commented Sep 28, 2023

Description

Add excluding in Japanese translation

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Run tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

No screenshots

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

While the file formatting looks good, I'm not sure that this is an accurate translation in context.

The way things are set up right now, this translation will result in the note saying "* 除きます 日, 月"

As far as I know, 除きます is a verb form which would have to go at the end of the sentence to make sense.

It seems that most ways to write it would require putting the word excluding at the end which is currently not supported.

Possibly the phrase 除外日: ("excluded days:") might work, but I think I think we should get additional feedback on this.

I've requested external help and I'll let you know what I find out.

@Achixz
Copy link
Author

Achixz commented Sep 28, 2023

Thanks for contributing.

While the file formatting looks good, I'm not sure that this is an accurate translation in context.

The way things are set up right now, this translation will result in the note saying "* 除きます 日, 月"

As far as I know, 除きます is a verb form which would have to go at the end of the sentence to make sense.

It seems that most ways to write it would require putting the word excluding at the end which is currently not supported.

Possibly the phrase 除外日: ("excluded days:") might work, but I think I think we should get additional feedback on this.

I've requested external help and I'll let you know what I find out.

Yes, that's a good idea, rather than having to force the use of that word.

@DenverCoder1
Copy link
Owner

Based on feedback I received from other translators, as I expected, translating this phrase into Japanese is more difficult than what is currently supported by the code. To provide the best translation, we need to support putting the days before the translation for the word excluding, support changing the comma separator (this can be useful for Arabic script languages as well), and we need to make Japanese use the full day names instead of the single-character abbreviations to make sense in context.

Since there are many code changes necessary, I opened a separate PR for supporting all of these adjustments to make translating this phrase possible.

Sorry for the inconvenience of having to close this PR, but feel free to let me know if you have any thoughts on #604

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy