Prevent Freehand and Line tools from creating empty layers when clicking but not dragging to draw #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing2.mp4I tried your changes locally. In the Freehand Tool, after drawing a line, clicking on its endpoint causes the line to be deleted. |
|
@Abhinavpatel00 I've marked this PR as a draft while awaiting fixes. Once you have the issues resolved, please mark it as Ready for Review and leave a comment. Thanks! |
c7488cf to
1875779
Compare
ec51271 to
e025103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip node creation for zero-length lines in Line tool and drawings in Freehand tool