Add X and Y offset distance overlay while dragging with the Select tool #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
0HyperCube
reviewed
Jul 5, 2025
|
Could you please check if it has all the expected behaviours. |
|
Keavon
approved these changes
Jul 9, 2025
|
@Kavin006 looks like the pivot stored in select tool is viewport space and doesn't respect PTZ changes. output2.mp4 |
|
Didn't realise this could happen. I feel like we have to add the document position of drag start to SelectToolData to fix this. This is also the case with the selection box unless its intended there. |
|
It works correctly when you pan (e.g. scroll with the mouse wheel) with |
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…ol (GraphiteEditor#2814) * Add offset overlay to select tool * Add overlay to Dragging * Add axis align behavior * Style changes * Add trim to string * reduce code duplication * Code review --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.