General Purpose Value Node #2822
Conversation
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
Outdated
Show resolved
Hide resolved
7b5ae89 to
4075003
Compare
| let value_dropdown = enum_choice::<TaggedValueChoice>().dropdown_menu(choice, updater, || commit_value); | ||
| select_value_widgets.extend_from_slice(&[Separator::new(SeparatorType::Unrelated).widget_holder(), value_dropdown]); | ||
|
|
||
| let mut type_widgets = match property_from_type(node_id, 0, &input_type, (None, None, None), None, None, None, false, context) { |
There was a problem hiding this comment.
I noticed that the following types don't have a working properties: OptionalF64, OptionalDVec2, VecU64, F64Array4.
Also the VectorData says "Vector data is supplied through the node graph". However this is misleading as there is no way to actually expose the input to the graph. This is also inconsistent with the other complex types e.g. GraphicElement, which currently just displays a "-".
There was a problem hiding this comment.
The - is newer and we can probably just standardize on that for all the types we don't yet have widgets for. We'll someday even have a widget for vector with some kind of way to visualize the path in a box that you can click on to view larger or something (I haven't thought much about this design, but that's the notion).
ec51271 to
e025103
Compare
|
I'm momentarily converting this to a draft while I work through my PR queue since this has merge conflicts and a test failure in CI. It appears to be an exciting change so I look forward to having the chance to review and land this. Thanks :) |
8e04531 to
940c714
Compare
d2d67df to
7336028
Compare
When an exposed value input is clicked with alt pressed and dragged, a value node with that same input is created, and connected to the node. Removes all value nodes and replaced with the generic value node.
TODO: Migrate fill to be input type based to close #2875
chrome_XxACq43Yeq.mp4
Essentially closes #2447
Closes #1919, #2567