Refactor node migration to be less susceptible to forgetting outdated strings #2853
+459
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
approved these changes
Jul 11, 2025
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
… strings (GraphiteEditor#2853) * migration: make document migration use ProtoNodeIdentifier * migration: NodeReplacement struct for better formatting * migration: test for duplicates and fix them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_node::IDENTIFIERforces a change in the migration when a node is renamed or movedBy adding this much validation, multiple inconsistencies in node migration have been found and fixed. Hopefully, a lot of failing documents now migrate smoothly.