Skip to content

Add shaking input gesture to disconnect a node being dragged #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add shaking input gesture to disconnect a node being dragged #2889

wants to merge 5 commits into from

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Jul 16, 2025

Closes #904

@Keavon Keavon requested a review from adamgerhant July 16, 2025 00:55
@github-actions GitHub Actions
Copy link

Performance Benchmark Results

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 26,723,819 (master) -> 25,416,109 (HEAD) : $$\color{lime}-4.89\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     329,273|    315,284          -4.25%
D1mw                     104,478|     99,058          -5.19%
DLmr                      32,707|     29,345         -10.28%
DLmw                      44,970|     49,474         +10.02%
Dr                     6,483,093|  6,151,398          -5.12%
Dw                     4,584,948|  4,354,225          -5.03%
EstimatedCycles       42,095,536| 40,200,552          -4.50%
I1mr                      53,043|     57,718          +8.81%
ILmr                         873|        867          -0.69%
Ir                    26,723,819| 25,416,109          -4.89%
L1hits                37,305,066| 35,449,672          -4.97%
LLhits                   408,244|    392,374          -3.89%
RamHits                   78,550|     79,686          +1.45%
TotalRW               37,791,860| 35,921,732          -4.95%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 13,656,829 (master) -> 13,132,784 (HEAD) : $$\color{lime}-3.84\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     162,061|    157,743          -2.66%
D1mw                      51,277|     50,399          -1.71%
DLmr                         806|        512         -36.48%
DLmw                      16,427|     15,747          -4.14%
Dr                     3,314,750|  3,180,883          -4.04%
Dw                     2,334,032|  2,242,150          -3.94%
EstimatedCycles       20,797,141| 20,013,781          -3.77%
I1mr                      24,807|     28,954         +16.72%
ILmr                         732|        727          -0.68%
Ir                    13,656,829| 13,132,784          -3.84%
L1hits                19,067,466| 18,318,721          -3.93%
LLhits                   220,180|    220,110          -0.03%
RamHits                   17,965|     16,986          -5.45%
TotalRW               19,305,611| 18,555,817          -3.88%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 2,265,443 (master) -> 2,207,903 (HEAD) : $$\color{lime}-2.54\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      23,609|     22,647          -4.07%
D1mw                      10,905|     10,944          +0.36%
DLmr                          20|         20          +0.00%
DLmw                       1,963|      1,303         -33.62%
Dr                       523,555|    510,449          -2.50%
Dw                       382,586|    372,708          -2.58%
EstimatedCycles        3,412,530|  3,310,244          -3.00%
I1mr                       5,465|      5,950          +8.87%
ILmr                         718|        711          -0.97%
Ir                     2,265,443|  2,207,903          -2.54%
L1hits                 3,131,605|  3,051,519          -2.56%
LLhits                    37,278|     37,507          +0.61%
RamHits                    2,701|      2,034         -24.69%
TotalRW                3,171,584|  3,091,060          -2.54%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 14,823,764 (master) -> 14,459,340 (HEAD) : $$\color{lime}-2.46\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     192,088|    186,631          -2.84%
D1mw                      67,402|     65,839          -2.32%
DLmr                          73|         52         -28.77%
DLmw                      18,141|     17,264          -4.83%
Dr                     3,566,585|  3,465,252          -2.84%
Dw                     2,550,868|  2,481,574          -2.72%
EstimatedCycles       22,634,279| 22,051,296          -2.58%
I1mr                      20,773|     22,605          +8.82%
ILmr                         853|        845          -0.94%
Ir                    14,823,764| 14,459,340          -2.46%
L1hits                20,660,954| 20,131,091          -2.56%
LLhits                   261,196|    256,914          -1.64%
RamHits                   19,067|     18,161          -4.75%
TotalRW               20,941,217| 20,406,166          -2.56%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,238,551 (master) -> 30,729,949 (HEAD) : $$\color{lime}-4.68\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     410,111|    392,908          -4.19%
D1mw                     135,485|    129,258          -4.60%
DLmr                      46,358|     42,401          -8.54%
DLmw                      63,046|     57,091          -9.45%
Dr                     7,756,494|  7,379,605          -4.86%
Dw                     5,501,149|  5,234,100          -4.85%
EstimatedCycles       51,220,580| 48,696,002          -4.93%
I1mr                      58,363|     63,146          +8.20%
ILmr                         881|        878          -0.34%
Ir                    32,238,551| 30,729,949          -4.68%
L1hits                44,892,235| 42,758,342          -4.75%
LLhits                   493,674|    484,942          -1.77%
RamHits                  110,285|    100,370          -8.99%
TotalRW               45,496,194| 43,343,654          -4.73%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 20,277,972 (master) -> 19,251,319 (HEAD) : $$\color{lime}-5.06\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     251,141|    239,041          -4.82%
D1mw                      80,610|     77,787          -3.50%
DLmr                      14,768|     12,760         -13.60%
DLmw                      31,321|     29,056          -7.23%
Dr                     4,903,545|  4,645,192          -5.27%
Dw                     3,470,336|  3,289,550          -5.21%
EstimatedCycles       31,543,645| 29,903,731          -5.20%
I1mr                      39,522|     43,067          +8.97%
ILmr                         801|        787          -1.75%
Ir                    20,277,972| 19,251,319          -5.06%
L1hits                28,280,580| 26,826,166          -5.14%
LLhits                   324,383|    317,292          -2.19%
RamHits                   46,890|     42,603          -9.14%
TotalRW               28,651,853| 27,186,061          -5.12%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgerhant adamgerhant adamgerhant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shake a node to un-wire its connection through its primary input/output
2 participants
@Keavon @adamgerhant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy