Skip to content

Move symfony/templating to dev dependencies #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move symfony/templating to dev dependencies #179

wants to merge 1 commit into from

Conversation

GromNaN
Copy link

@GromNaN GromNaN commented Jul 28, 2023 •
edited
Loading

symfony/templating is already an optional dependency. There's no reason to force its installation when even symfony/twig-bundle isn't required.

KnpTimeBundle/src/DependencyInjection/KnpTimeExtension.php

Lines 23 to 25 in db45362

if (class_exists(Helper::class)) {
$loader->load('templating.xml');
}

This component might be deprecated symfony/symfony#51144

@kbond
Copy link
Contributor

kbond commented Jul 28, 2023

This was done in #141 but reverted in #172 because of #171.

@GromNaN
Copy link
Author

GromNaN commented Jul 28, 2023 •
edited
Loading

The twig extension is also depending on a twig class, but that's not an issue with symfony/twig-bundle as a dev dependency.

@kbond
Copy link
Contributor

kbond commented Jul 28, 2023

I know... not sure why it was reverted.

@weaverryan
Copy link
Collaborator

I'm thinking that we merge this, #178 and #177 and do a 2.0 release. Then it's no worries either way.

@kbond kbond mentioned this pull request Jul 31, 2023
Merged
@weaverryan
Copy link
Collaborator

Done now in #178 :)

@GromNaN GromNaN deleted the patch-1 branch July 31, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @kbond @weaverryan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy