-
-
Notifications
You must be signed in to change notification settings - Fork 113
Added Authorize Command. #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution ❤ |
Looking great so far, just that minor tweak and it should be good to PR. |
I'm using the authcode returned by the Authorize command to Authenticate with the REST API. I'm not sure how to fix the issues in the static analysis. My implementation is identical to the code you already had in there for other commands, they seem like false positives. |
Dont worry about the static code analysis, that is just a general thumb to ensure quality and not strict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I seemed to hot have submitted this.
I require this to be moved up.
I do apologise, this was one of my first GitHub PRs at the time.
/// <summary> | ||
/// The OAuth2 authorization code | ||
/// </summary> | ||
public string Code { get; internal set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
properties should be defined above the contructor.
This PR adds support for the Authorize command. I needed to be able to request additional scopes. This allows me to have the authorization prompt show up in the discord client app.