Skip to content

refactor(core): zero circulars + esm ready #10770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Jul 25, 2025

  • resolves all 190+ circulars
  • provides esm ready distribution
  • provides bundling support for esm
  • provides esm hooks

TODO:

  • Isolate webpack changes into separate pull request
  • Remove extra test logging
  • Check if @nativescript/hook needs to conditionally create .js or .mjs based on bundling settings if possible (for backwards compat of <9 cli with >=9 core)

Notes:
@nativescript/webpack can be released as a patch as it's backwards compat now. It's been on a 5.1.x esm tag while testing however it's proven fully backwards compatible so a patch would be fine and likely recommended so users don't need to think about cjs v esm.

Copy link

nx-cloud bot commented Jul 25, 2025

View your CI Pipeline Execution ↗ for commit b9b234d

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 4m 38s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-25 20:38:28 UTC

@NathanWalker NathanWalker changed the title refactor: zero circulars and esm ready refactor(core): zero circulars + esm ready Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy