Fix for iOS 11 ListView top offset #4919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign CLA at http://www.nativescript.org/cla |
vakrilov
approved these changes
Oct 5, 2017
|
My PR will resolve ios 11 layout issues and will make this property working out-of-the box. So I think we |
|
As noted in my PR comment, if we can take advantage of the new behavior without the current issues that would be great. Feel free to skip this PR if you have made the new behavior work out of the box. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue #4916. In iOS 11 there is a new contentInsetAdjustmentBehavior behavior of the UIScrollView which is inherited by the ListView's UITableView. The default value of this new behavior is automatic which adjusts the top offset as described by the API description:
After this PR it may be a good feature to actually support the new different value of this new behavior, at the moment the animations provided by this behavior are not working inside the {N} layouts (GridLayout, StackLayout etc.)