Skip to content

fix: prevent errors on launching manual testing app #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2018
Merged

fix: prevent errors on launching manual testing app #6464

merged 5 commits into from
Nov 1, 2018

Conversation

danbockapps
Copy link
Contributor

PR Checklist

What is the current behavior?

tns run ios --path apps doesn't launch the manual testing app because the tslib module isn't found. Also, there are error messages about 'sourceMap' cannot be specified with option 'inlineSourceMap'.

What is the new behavior?

The manual testing app does launch, and the sourceMap errors are gone.

Fixes/Implements/Closes #[Issue Number].

@ghost ghost added the ♥ community PR label Oct 26, 2018
@vchimev
Copy link
Contributor

vchimev commented Oct 28, 2018 •
edited
Loading

Hey @danbockapps,

Thank you for the pull request. It was nice meeting you at jsMobileConf.

Let us check once again the TypeScript error and then proceed with merging.

Thanks once again.

@ghost ghost assigned vchimev Nov 1, 2018
@ghost ghost added in progress and removed ♥ community PR labels Nov 1, 2018
@vchimev
Copy link
Contributor

vchimev commented Nov 1, 2018

Hey @danbockapps,

I removed the extends option from apps/tsconfig.json and updated the file to defaults.

Thank you for letting us know about these.

@vchimev vchimev merged commit eca938d into NativeScript:master Nov 1, 2018
@ghost ghost removed the in progress label Nov 1, 2018
vchimev added a commit that referenced this pull request Nov 2, 2018
@vchimev
Revert "chore(apps): add tslib dep and update tsconfig.json file (#6464…
f54f7c3 
…)"

This reverts commit eca938d.
@radeva
Copy link

radeva commented Nov 19, 2018

Hi @danbockapps ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

@lock
Copy link

lock bot commented Nov 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vchimev vchimev vchimev approved these changes

Assignees

@vchimev vchimev

Labels
cla: yes ♥ community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danbockapps @vchimev @radeva @ns-bot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy