Skip to content

Resolve incorrect name of listener when unsubscribing causing Views to be leaked in memory #6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

VladimirAmiorkov
Copy link
Contributor

This is a resurrection of the #6353 but it fixed the source rather than the effect that causes memory leak in NativeScript + Angular apps that use ListView or RadListView from nativescript-ui-listview plugin.

PR Checklist

What is the current behavior?

When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are left in the memory

What is the new behavior?

When using the Angular createEmbeddeedView from the ViewContainerRef, after calling clear() the created NativeScript Views are collected by the GC and a no longer in the memory

Fixes/Implements/Closes #[Issue Number].
ProgressNS/nativescript-ui-feedback#825

@VladimirAmiorkov VladimirAmiorkov merged commit 2933a9a into master Nov 2, 2018
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/embedded-views-leak-fix branch November 2, 2018 13:33
@ghost ghost removed the in progress label Nov 2, 2018
@lock
Copy link

lock bot commented Nov 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy