Clarify that SdkAnalysisLevel impacts more than just this warning #3447
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a documentation note to clarify that changing SDKAnalysisLevel affects more than just the NU1302 warning being discussed. The change adds a reference note directing users to the official SDK documentation for comprehensive information about all features impacted by SDKAnalysisLevel.
- Adds a note section with disclaimer about
SDKAnalysisLevelside effects - References the official .NET SDK documentation for complete feature scope
Comments suppressed due to low confidence (1)
docs/reference/errors-and-warnings/NU1302.md:55
- The property name casing is inconsistent. The text uses 'SDKAnalysisLevel' but the link references 'SdkAnalysisLevel'. Both should use the same casing for consistency.
> Changing SDKAnalysisLevel has other side-effects as well. Refer to the [`SdkAnalysisLevel`](/dotnet/core/project-sdk/msbuild-props#sdkanalysislevel) for a summary of the full scope of .NET SDK features affected.
|
Learn Build status updates of commit 3f97e7c: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 1b0bba6: ✅ Validation status: passed
For more details, please refer to the build report. |
| @@ -51,4 +51,5 @@ Here's how it functions: | |||
| - For SDK Analysis Level value **below 9.0.100**, using HTTP sources triggers a warning ([NU1803](NU1803.md)). | |||
| - Starting with SDK Analysis Level **9.0.100 or higher**, HTTP sources result in an error (NU1302) unless `AllowInsecureConnections` is explicitly enabled. | |||
|
|
|||
|
|
|||
| > [!NOTE] | |||
There was a problem hiding this comment.
Should we consider a different alert, perhaps warning, caution, or important?
There was a problem hiding this comment.
You are maybe, at least an Important, but possibly a warning. I feel like Caution is potentially too much.
@baronfel what do you think about this?
Progress on NuGet/Home#14369.
The idea is that we'd be adding this disclaimer to every place we recommend SDKAnalysisLevel.
My plan is to update https://github.com/NuGet/NuGet.Client/blob/dev/docs/feature-guide.md#warnings-and-defaults once the wording here has been approved.