Hardening suggestions for jtd-codebuild / revert-3-pixeebot/drip-2024-02-17-pixee-python/subprocess-shell-false #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,10 +67,8 @@ def generate( | |||
| target_language = target["language"] | |||
| target_path = self.get_target_path(target) | |||
| safe_mkdir(target_path) | |||
| process = subprocess.Popen( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -19,10 +20,8 @@ def _compile_typescript(self, tsconfig_path: str) -> subprocess.Popen: | |||
| Args: | |||
| tsconfig_path: The path to the tsconfig.json file. | |||
| """ | |||
| return subprocess.run( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -14,8 +14,7 @@ def test_example_project_1(): | |||
| # Run the command | |||
| subprocess.check_call( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -13,8 +13,7 @@ def test_example_project_2(): | |||
| # Run the command | |||
| subprocess.check_call( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -13,8 +13,7 @@ def test_example_project_3(): | |||
| # Run the command | |||
| subprocess.check_call( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -13,8 +13,7 @@ def test_example_project_4(): | |||
| # Run the command | |||
| subprocess.check_call( | |||
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -66,10 +67,8 @@ def generate( | |||
| target_language = target["language"] | |||
| target_path = self.get_target_path(target) | |||
| safe_mkdir(target_path) | |||
| process = subprocess.Popen( | |||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| @@ -19,10 +20,8 @@ def _compile_typescript(self, tsconfig_path: str) -> subprocess.Popen: | |||
| Args: | |||
| tsconfig_path: The path to the tsconfig.json file. | |||
| """ | |||
| return subprocess.run( | |||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (5 - Revert "Use
shell=FalseinsubprocessFunction Calls") and have identified some area(s) that could benefit from additional hardening measures.These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot