Skip to content

[WASM] Remove numba and quantecon for WASM lectures #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 25, 2025

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Feb 18, 2025

Removes usage of numba and quantecon. Replace quantecon with quantecon_wasm. This is related to WASM lecture series since numba is not supported in pyodide.

@kp992 kp992 requested a review from mmcky February 18, 2025 02:17
@kp992 kp992 added the wasm label Feb 18, 2025
@kp992 kp992 changed the title [WASM] Remove numba from ar1_processes [WASM] Remove numba and quantecon for WASM lectures Feb 18, 2025
@kp992
Copy link
Contributor Author

kp992 commented Feb 18, 2025

@mmcky The failure shows that we will need a new release of quantecon_book_networks with updated dependencies.

@mmcky
Copy link
Contributor

mmcky commented Feb 18, 2025

@kp992
Copy link
Contributor Author

kp992 commented Feb 18, 2025

Thanks @mmcky. This looks perfect.

@kp992
Copy link
Contributor Author

kp992 commented Feb 19, 2025

The CI is green now. This script tests that all the used libraries in the lectures are installable in pyodide. I have skipped 3 files and we can iterate to fix this.

@mmcky
Copy link
Contributor

mmcky commented Feb 19, 2025

thanks @kp992 which three are they. The data lectures for wbapi and yfinance?

@kp992
Copy link
Contributor Author

kp992 commented Feb 20, 2025

thanks @kp992 which three are they. The data lectures for wbapi and yfinance?

'short_path.py',
'inflation_history.py',
'lp_intro.py', # remove ortools

The first 2 files have some issues while converting .md to .py. The last file is failing because ortools is not installable in WASM. The current script is just testing that all the used libraries are WASM compatible. We aren't actually running these .py files in the WASM environment we just installing libraries used in them. I have another script coming up soon which will actually run the lectures in WASM environment and check for failures.

@kp992
Copy link
Contributor Author

kp992 commented Feb 20, 2025

@mmcky does this look good to be merged now?

@kp992
Copy link
Contributor Author

kp992 commented Feb 20, 2025

I have updated the wasm branch to run all the generated files in pyodide environment and so can we verify that every new or existing files will run on WASM or not. The current failure shows that the script is working fine.

@kp992
Copy link
Contributor Author

kp992 commented Feb 25, 2025

Merging this to let other PRs build upon it. The error is expected.

@kp992 kp992 merged commit c84c821 into QuantEcon:wasm Feb 25, 2025
1 check failed
@kp992 kp992 deleted the wasm_pr1 branch February 25, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy