Skip to content

Fix uncaught exception when trying to retrieve negative addresses #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Fix uncaught exception when trying to retrieve negative addresses #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aff5f4d
Fix uncaught exception when trying to retrieve negative addresses
TETYYS Dec 7, 2018
1cf0097
Rewrite address to non-negative instead of rejecting it
TETYYS Dec 7, 2018
b461f39
Fix copy paste mistake
TETYYS Dec 7, 2018
2761d18
Fix copy paste mistake
TETYYS Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion LoadBinaryPluginExt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,18 @@ public bool ReadRemoteMemory(IntPtr process, IntPtr address, ref byte[] buffer,
{
try
{
using (var stream = info.File.CreateViewStream(address.ToInt64(), size))
/*
* This ensures that addresses larger than 0x7FFF_FFFF are not negative after calling
* ToInt64 by removing low side from long address from IntPtr (which seems to be casted
* from int to long non-bitwise). Same problem applies to addresses that are larger than
* 0x7FFF_FFFF_FFFF_FFFF, however CreateViewStream only accepts long parameter.
*/
long addressInt64 = address.ToInt64();
if (addressInt64 < 0)
{
addressInt64 &= 0xFFFF_FFFF;
}
using (var stream = info.File.CreateViewStream(addressInt64, size))
{
stream.Read(buffer, 0, size);

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy