upgrade serde and time #1210
Open
upgrade serde and time #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddm
reviewed
Jul 2, 2024
| serde = { version = "=1.0.184", features = ["derive"] } | ||
| serde_derive = "=1.0.184" | ||
|
|
||
| serde = { version = "=1.0.203", features = ["derive"] } |
There was a problem hiding this comment.
We can unfreeze serde if we port the cargo-deny support from the other projects. See: https://github.com/RedisGears/RedisGears/blob/master/deny.toml
e4d940a to
f6aa801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades serde to 1.0.184 and time to 0.3.36.
This PR solves build issues on with rustc nightly.
This PR also solves some build issues on macos