Skip to content

feat(a11y): Inline errors ReportUserView #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 24, 2025

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jun 18, 2025

Proposed changes

Create inline error on avatar url input in ReportUserView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-243

How to test or reproduce

  • Open the app;
  • Go to a Room;
  • Try to report a user;

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2025-06-24 at 12 07 10 Simulator Screenshot - iPhone 16 - 2025-06-24 at 12 06 45

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak force-pushed the feat-a11y-inlineerrors-reportuserview branch from 5076a02 to 1785b89 Compare June 18, 2025 17:20
@OtavioStasiak OtavioStasiak marked this pull request as ready for review June 24, 2025 15:08
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build July 22, 2025 20:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build July 22, 2025 20:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_ios_build July 22, 2025 20:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_ios_build July 23, 2025 16:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build July 23, 2025 16:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build July 23, 2025 16:54 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build July 23, 2025 19:25 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build July 23, 2025 19:25 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_ios_build July 23, 2025 19:25 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak merged commit 88cb616 into develop Jul 24, 2025
11 of 19 checks passed
@OtavioStasiak OtavioStasiak deleted the feat-a11y-inlineerrors-reportuserview branch July 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy