Skip to content

feat(a11y): inline errors createDiscussionView #6487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

feat(a11y): inline errors createDiscussionView #6487

wants to merge 13 commits into from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jul 9, 2025 •
edited
Loading

Proposed changes

Create inline errors in createDiscussionView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-245

How to test or reproduce

  • Open the app;
  • Try to create a discussion name input empty;

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak temporarily deployed to experimental_ios_build July 25, 2025 17:46 — with GitHub Actions Inactive
@OtavioStasiak OtavioStasiak temporarily deployed to experimental_android_build July 25, 2025 17:46 — with GitHub Actions Inactive
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 25, 2025 17:46 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to upload_experimental_android July 25, 2025 18:02 — with GitHub Actions Error
@github-actions GitHub Actions
Copy link

Android Build Available

Rocket.Chat Experimental 4.63.0.93293

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSok5OK3lLf8NbjsQGkeW4uj7SVZwGU2j_WBFkEZe20Ry4rzZlU6RvikPDm-yxxvMAED70geZVPeYt39IIy

@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 25, 2025 18:17 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 28, 2025 17:16 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 28, 2025 17:16 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 28, 2025 17:16 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build July 31, 2025 22:06 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build July 31, 2025 22:06 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build July 31, 2025 22:06 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak marked this pull request as ready for review July 31, 2025 22:25
@OtavioStasiak OtavioStasiak requested a deployment to experimental_android_build July 31, 2025 22:37 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to official_android_build July 31, 2025 22:37 — with GitHub Actions Waiting
@OtavioStasiak OtavioStasiak requested a deployment to experimental_ios_build July 31, 2025 22:37 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OtavioStasiak
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy