-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(a11y): inline errors profileView #6488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Android Build Available Rocket.Chat Experimental 4.63.0.87790 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRIs9fwwnEJ6CBDFAPG0aLxVfRmy5HEQnO-4arBlfQhXFvKRQAiyfWmKxrJQYwP6E9Bg7B0_2V9BtXKHNFl |
I noticed one issue but not sure if this PR introduce that If we change email to an existing one it shows the error modal but text input keeps the new email instead of reverting to old one even if I change the screen too Steps:-
It only revert to old if we restart the app. |
iOS Build Available Rocket.Chat Experimental 4.63.0.87790 |
It's happening in development as well. I'll fix it in this PR. Thanks @Rohit3523 🙏🏻
|
Proposed changes
Issue(s)
https://rocketchat.atlassian.net/browse/MA-256
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments