Allow for different demo snippets to be selected #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check this issue, it contains mandelbrot.py: |
| count = 0 | ||
| until = 10 | ||
|
|
||
| print(f"These are the first {until} numbers in the Fibonacci sequence:") |
|
It takes a while to run, for me about 20 seconds, and the page is frozen during that time. It's a good example, though. |
|
I think it could be improved by a requestAnimationFrame call, but that would be for another PR to add that as a builtin. |
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 48.41% 48.41%
=======================================
Files 69 69
Lines 14375 14375
Branches 3591 3591
=======================================
Hits 6960 6960
Misses 5554 5554
Partials 1861 1861Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection works, but I'm looking for ideas for what other snippets could be put there. Everything's stored in
wasm/demo/snippets/*.py; a separate demo snippet would mean a new.pyfile in that directory.