Skip to content

Update zipfile to 3.13.5 #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update zipfile to 3.13.5 #6069

wants to merge 2 commits into from

Conversation

jackoconnordev
Copy link
Contributor

@jackoconnordev jackoconnordev commented Aug 5, 2025 •
edited
Loading

Description

Update zipfile library and related tests to 3.13.5.

New TODOs

  • Skipped some new tests due to shift_jis encoding not being supported
  • test_write_filtered_python_package marked as expectedFailure due to "AttributeError: module 'os' has no attribute 'supports_effective_ids'"

Windows tests

I don't have access to a Windows machine so don't have a readily available way to run these tests in verbose mode locally 🤔.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 5, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (16)
  • Lib/test/archiver_tests.py is excluded by !Lib/**
  • Lib/test/test_zipfile/__init__.py is excluded by !Lib/**
  • Lib/test/test_zipfile/__main__.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/__init__.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/_functools.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/_itertools.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/_support.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/_test_params.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/test_complexity.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/test_path.py is excluded by !Lib/**
  • Lib/test/test_zipfile/_path/write-alpharep.py is excluded by !Lib/**
  • Lib/test/test_zipfile/test_core.py is excluded by !Lib/**
  • Lib/zipfile/__init__.py is excluded by !Lib/**
  • Lib/zipfile/__main__.py is excluded by !Lib/**
  • Lib/zipfile/_path/__init__.py is excluded by !Lib/**
  • Lib/zipfile/_path/glob.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Jack O'Connor added 2 commits August 5, 2025 13:18
Add Lib/test/archiver_tests.py @ 3.13.5
0533474 
Needed for updated zipfile tests.
Update zipfile to 3.13.5
60fad7a 
Notes:

- I have to skip some brand new tests due to shift_jis encoding not
being supported

- `test_write_filtered_python_package` marked as `expectedFailure` with
"AttributeError: module 'os' has no attribute 'supports_effective_ids'"
  - I didn't want to do a partial or full update to os module in this PR
@jackoconnordev jackoconnordev marked this pull request as ready for review August 5, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackoconnordev
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy