Skip to content

Major python code change #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 25, 2017
Merged

Major python code change #116

merged 21 commits into from
Jul 25, 2017

Conversation

Roosted7
Copy link
Member

Refractoring splash code

@Roosted7 Roosted7 self-assigned this Jul 24, 2017
@Roosted7 Roosted7 added the WIP label Jul 24, 2017
@Roosted7
Copy link
Member Author

Do NOT merge yet :)

raboof
raboof reviewed Jul 25, 2017
View reviewed changes
esp32/modules/splash.py Outdated
@@ -192,360 +74,221 @@ def draw_helper_battery(percent,cstate):
else:
ugfx.string(5,5,"empty","Roboto_Regular12",header_bg)
else:
ugfx.string(2,5,"no batt","Roboto_Regular12",header_bg)

ugfx.string(2,5,"no batt","Roat_status = boto_Regular12",header_bg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A stray at_status = appeared :)

@Roosted7
Copy link
Member Author

So, this now is flashable and kinda usable...
Will sort out the bugs later to make this mergable

raboof
raboof reviewed Jul 25, 2017
View reviewed changes
esp32/modules/appglue.py Outdated
if (app==""):
ugfx.string(0, 25, "Returning to homescreen...","Roboto_Regular12",ugfx.BLACK)
else:
ugfx.string(0, 25, "Starting "+app+"...","Roboto_Regular12",ugfx.BLACK)
ugfx.set_lut(ugfx.LUT_FASTEST)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to set_lut separately, you can pass ugfx.LUT_FASTEST to ugfx.flush()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@renzenicolai
Copy link
Member

Hmm, I misunderstood bpp then. We do need a way to set the maximum time bpp will be active though.

@Roosted7 Roosted7 changed the title Splashscreen cleanup Python code cleanup Jul 25, 2017
@Roosted7 Roosted7 changed the title Python code cleanup Major python code change Jul 25, 2017
@Roosted7 Roosted7 requested a review from Kartoffel July 25, 2017 21:05
@Kartoffel
Copy link
Member

Please make sure the badge does not go to sleep when plugged in through USB, this makes the REPL a bit difficult to use

@Kartoffel
Copy link
Member

The splash may take a bit longer refreshing after a reset, it can be a bit ugly when exiting an app.

Have you thought about doing a nice and slow refresh before going to auto-sleep?

@Kartoffel
Copy link
Member

Kartoffel commented Jul 25, 2017 •
edited
Loading

Pressing "B" to launch the OTA update does not work.

Change label "[B: OTA]" --> "[B: Update]"

@Kartoffel
Copy link
Member

Kartoffel commented Jul 25, 2017 •
edited
Loading

Tiny bug, it appears that my battery is a bit full. LOL.

(At 100% or 4.2V)

Unplugging charger reports a voltage of 4.31V

@Roosted7 Roosted7 merged commit 3d81d93 into master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof left review comments

@Kartoffel Kartoffel Awaiting requested review from Kartoffel

Assignees

@Roosted7 Roosted7

Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Roosted7 @renzenicolai @Kartoffel @raboof @annejan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy