Add power management to launcher #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Aug 2, 2017
| selected = options.selected_text() | ||
| options.destroy() | ||
| appglue.start_app(selected) | ||
| def run_it(): |
There was a problem hiding this comment.
I like handling the pushed check outside of this function, much neater 👍
|
|
||
| ugfx.input_attach(ugfx.JOY_UP, lambda pushed: ugfx.flush() if pushed else 0) | ||
| ugfx.input_attach(ugfx.JOY_DOWN, lambda pushed: ugfx.flush() if pushed else 0) | ||
| def input_a(pressed): |
There was a problem hiding this comment.
These generic input_x seem like unnecessary/confusing indirection to me, I'd personally prefer a small lambda when attaching the input handler. Might be a matter of taste, so OK.
| # Power management | ||
| virtualtimers.activate(1000) # Start scheduler with 1 second ticks | ||
| pm.set_timeout(5*60*1000) # Set timeout to 5 minutes | ||
| pm.callback(pm_cb) # Go to splash instead of sleep |
There was a problem hiding this comment.
would also be more readable as a lambda imho: pm.callback(lambda: appglue.home())
There was a problem hiding this comment.
(actually surprised your original approach pm.callback(appglue.home) didn't work, weird)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.