You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
added 3 exceptions in error doc
Motivation and Context
added 3 exceptions in error doc
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
I have used hugo to render the site/docs locally and I am sure it works.
PR Type
Documentation
Description
Added three new WebDriver exception types to error documentation
Included detailed causes and solutions for each exception
Enhanced troubleshooting guide with practical examples
Diagram Walkthrough
flowchart LR
A["Error Documentation"] --> B["NoSuchAlertException"]
A --> C["NoSuchElementException"]
A --> D["NoSuchFrameException"]
B --> E["Causes & Solutions"]
C --> E
D --> E
Loading
File Walkthrough
Relevant files
Documentation
_index.en.md
Added three WebDriver exception types with troubleshooting guidance
Heading levels are inconsistent: sections use '##' for exception names, but 'Possible Solutions' under NoSuchAlertException is '##' instead of '###' like other sections. Align heading hierarchy for TOC and styling consistency.
## Possible Solutions* Use explicit waits for alert presence: WebDriverWait(driver, 10).until(EC.alert_is_present())
* Check if alert is actually present before interaction
* Handle timing issues with alert appearance by adding appropriate delays
* Verify the action that should trigger the alert is actually executed before attempting to handle it
Imperative bullet points mix punctuation and style; consider consistent sentence casing and ending punctuation, and avoid advising arbitrary delays—prefer explicit waits.
* Use explicit waits for alert presence: WebDriverWait(driver, 10).until(EC.alert_is_present())
* Check if alert is actually present before interaction
* Handle timing issues with alert appearance by adding appropriate delays
* Verify the action that should trigger the alert is actually executed before attempting to handle it
Inline code examples reference WebDriverWait, EC, By without import context; ensure examples are language-scoped and formatted consistently, possibly as code blocks with imports for clarity.
* Use explicit waits to ensure element is present before interaction: WebDriverWait(driver, 10).until(EC.presence_of_element_located((By.ID, "element-id")))
* Verify the locator is correct by testing it in browser developer tools
* Check if element is in a different frame and switch context if needed
* Wait for dynamic content to load before searching for the element
* Use more robust locator strategies (ID, CSS selectors, XPath)
## NoSuchFrameException
A command to switch to a frame could not be satisfied because the frame could not be found.
### Likely Cause* Frame doesn't exist or was removed from DOM
* Incorrect frame identifier (name, id, or index)
* Frame not yet loaded when attempting to switch
* Using wrong frame reference (outdated index or incorrect name)
* Frame is nested and requires switching to parent frame first
### Possible Solutions* Verify frame exists using browser developer tools
* Use correct frame identifier (name, id, or WebElement reference)
* Wait for frame to be available: WebDriverWait(driver, 10).until(EC.frame_to_be_available_and_switch_to_it("frame-name"))
* Check frame hierarchy and switch to parent frames in correct order for nested frames
The new sections include Python-specific code (WebDriverWait, EC usage) in a general documentation page without labeling it as Python or providing equivalents, which can mislead users of other languages. Either mark these snippets explicitly as Python and add links/equivalents for other bindings, or present language-agnostic patterns to keep the page consistent and cross-language.
* Use explicit waits to ensure element is present before interaction: WebDriverWait(driver, 10).until(EC.presence_of_element_located((By.ID, "element-id")))
Solution Walkthrough:
Before:
## Possible Solutions* Use explicit waits to ensure element is present before interaction: WebDriverWait(driver, 10).until(EC.presence_of_element_located((By.ID, "element-id")))
* Verify the locator is correct by testing it in browser developer tools
* ...
After:
## Possible Solutions***(Python)** Use explicit waits to ensure element is present before interaction: `WebDriverWait(driver, 10).until(EC.presence_of_element_located((By.ID, "element-id")))`***(Java)** Use explicit waits: `new WebDriverWait(driver, Duration.ofSeconds(10)).until(ExpectedConditions.presenceOfElementLocated(By.id("element-id")));`* Verify the locator is correct by testing it in browser developer tools
* ...
Suggestion importance[1-10]: 8
__
Why: The suggestion correctly identifies that Python-specific code is used in general documentation, which is a significant issue for a multi-language tool like Selenium, making the documentation confusing for non-Python users.
Medium
General
Make code snippet self-contained
Prefix code with a language identifier and wrap it in code fences to avoid rendering issues and ensure proper syntax highlighting. Also import required classes in the snippet so it is copy-paste runnable.
-* Use explicit waits for alert presence: WebDriverWait(driver, 10).until(EC.alert_is_present())+```python+from selenium.webdriver.support.ui import WebDriverWait+from selenium.webdriver.support import expected_conditions as EC+WebDriverWait(driver, 10).until(EC.alert_is_present())+```+
Apply / Chat
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly proposes to make the code example runnable by adding necessary imports and wrapping it in a Python code block, which significantly improves the quality and usability of the documentation.
Low
Provide runnable wait example
Wrap the example in a fenced Python block and include the necessary imports so readers can run it directly without NameError exceptions. This prevents confusion and improves documentation reliability.
-* Use explicit waits to ensure element is present before interaction: WebDriverWait(driver, 10).until(EC.presence_of_element_located((By.ID, "element-id")))+```python+from selenium.webdriver.common.by import By+from selenium.webdriver.support.ui import WebDriverWait+from selenium.webdriver.support import expected_conditions as EC+WebDriverWait(driver, 10).until(+ EC.presence_of_element_located((By.ID, "element-id"))+)+```+
Apply / Chat
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly proposes to make the code example runnable by adding necessary imports and wrapping it in a Python code block, which significantly improves the quality and usability of the documentation.
Low
Make frame-switch examples runnable
Convert inline examples into fenced, self-contained Python snippets with the necessary imports, and demonstrate both name-based and WebElement-based switching safely. This avoids undefined-name errors and clarifies correct usage.
-* Wait for frame to be available: WebDriverWait(driver, 10).until(EC.frame_to_be_available_and_switch_to_it("frame-name"))-* Use frame WebElement instead of name/id: driver.switch_to.frame(driver.find_element(By.TAG_NAME, "iframe"))+```python+# Switch by name/id when known+from selenium.webdriver.support.ui import WebDriverWait+from selenium.webdriver.support import expected_conditions as EC+WebDriverWait(driver, 10).until(+ EC.frame_to_be_available_and_switch_to_it("frame-name")+)+```+```python+# Switch using a WebElement reference+from selenium.webdriver.common.by import By++iframe = driver.find_element(By.TAG_NAME, "iframe")+driver.switch_to.frame(iframe)+```+
Apply / Chat
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly proposes to make the code examples runnable by adding necessary imports and wrapping them in Python code blocks, which significantly improves the quality and usability of the documentation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
added 3 exceptions in error doc
Motivation and Context
added 3 exceptions in error doc
Types of changes
Checklist
PR Type
Documentation
Description
Added three new WebDriver exception types to error documentation
Included detailed causes and solutions for each exception
Enhanced troubleshooting guide with practical examples
Diagram Walkthrough
File Walkthrough
_index.en.md
Added three WebDriver exception types with troubleshooting guidancewebsite_and_docs/content/documentation/webdriver/troubleshooting/errors/_index.en.md
handling issues
location problems
switching errors