Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SortableJS/react-sortablejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.1
Choose a base ref
...
head repository: SortableJS/react-sortablejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.2
Choose a head ref
  • 15 commits
  • 6 files changed
  • 4 contributors

Commits on Oct 7, 2020

  1. Fix issue when one of a children is undefined

    Firstly huge thanks for such amazing module!
    In some edge cases (like in my own) there can be a `undefined` React child. Easy to reproduce:
    ```js
    <ReactSortable>
      {some_var ? <li>123</li> : undefined}
      <li>123</li>
    </ReactSortable>
    ```
    
    In such case crash happen because code can't read property of undefined object.
    Just check changes that I made into `react-sortable.tsx` file you will understand what I'm trying to achieve.
    
    I also changed this line from `const item = list[index];` to `const item = list[index] || {};` , just to be sure that if list doesn't have particular index, whole code not fail.
    This two changes are made to prevent edge case crashes. In my own app I spend a lot of time to find out why sometime app is crashing.
    
    Please, please approve this pull request!
    Rustem Mussabekov authored Oct 7, 2020
    Configuration menu
    Copy the full SHA
    fad8236 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Configuration menu
    Copy the full SHA
    631e2d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17878f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a7cb54 View commit details
    Browse the repository at this point in the history
  4. fix: infra

    andresin87 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    1d43f97 View commit details
    Browse the repository at this point in the history
  5. chore: restore lock file

    andresin87 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    89e08f1 View commit details
    Browse the repository at this point in the history
  6. chore: restore lockfile

    andresin87 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    05d2444 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e82314b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3c42b97 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1000f68 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    48286f1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9c0660d View commit details
    Browse the repository at this point in the history
  12. chore: update libraries

    andresin87 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3ba6fc4 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f0bc39e View commit details
    Browse the repository at this point in the history
  14. chore(release): 6.0.2 [skip ci]

    ## [6.0.2](v6.0.1...v6.0.2) (2022-01-14)
    
    ### Bug Fixes
    
    * **remove unnecesary devdependencies:** rmeove innecesary devDependencies ([1000f68](1000f68))
    * infra ([1d43f97](1d43f97))
    semantic-release-bot committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    440cba4 View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy