Fix clone Urls #217
Merged
Fix clone Urls #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Noice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #214 but adding the 4 clone URL fields to the Repository class. I tried to keep things non-breaking by still having the
cloneUrlsobject but making it deprecated and lazy constructing it. Technically, the possibility of breakage is still possible if someone happens to be constructing aRepositoryobject and is passing a cloneUrls object in the constructor (since that is now gone from the constructor). I see this as very unlikely but let me know if this is a problem.I also fixed some URLs to the github v3 API docs while in there and used fieldRename: snake to remove some unneeded @JSON annotations.